Adding Player Handles

[faytey]

Context (Problem, Motivation, Solution)

Link related issues!
Issue 117

Describe Your Changes

I added the smart contract to implement Player handles and wrote the tests to check the functions work properly

Checklist

• I have performed a self-review of my code
• I ran make check and fixed resulting issues
• I ran the relevant tests and they all pass
• I wrote tests for my new features, or added regression tests for the bug I fixed

Testing

If you didn't write tests, explain how you made sure the code was correct and working as intended.

[faytey]

I need your review on this before proceeding @norswap , Also I'm encountering errors setting up the webapp

[faytey]

I need your review on this before proceeding @norswap , Also I'm encountering errors setting up the webapp

Hello @norswap still awaiting your review

[norswap]

Great work! Sorry again for the delay. Could you make the requested changes? I'll make sure to prioritize reviewing them now.

[norswap]

Note to myself: will probably want to change this to only support alphanumerics & dashes, underscores, square brackets (for cute clan names), spaces (but not more than one in a row, and not at the end or at the start of the handle), as well as put a max character limit.

Fine to leave this as is for this PR.

[faytey]

Hi Sir I'd get started on these and update, sorry for the delay

[faytey]

Hi Sir, I have made requested corrections

[norswap]

Great work! Could you just make sure the Mock ENS resolver is logged + included in deployments.ts as well?

[norswap]

Also it seems you've made changes to the lockfile, could just revert it to the master version so that no changes show? The current file seems incorrect in some way, as shown by the failing CI check.

[faytey]

Also it seems you've made changes to the lockfile, could just revert it to the master version so that no changes show? The current file seems incorrect in some way, as shown by the failing CI check.

Hi Sir, I didn't make any changes to the lockfile and can't seem to understand how to rectify it.

[norswap]

That was probably accidental, you can see it is changed in "Files changes" here on Github.

Fixing it requires a little bit of git foo:
You can revert it by using git checkout master -- pnpm-lock.yaml then git add pnpm-lock.yaml.
You could then git commit and push that, but let's squash all your commit together:
git reset --soft HEAD~7 && git commit

(The 7 here is the number of commits you've made, so if you add additional commits in between you need to update that number.)

Then finally git push --force-with-lease to replace the commits here with the single squashed commit.

[faytey]

That was probably accidental, you can see it is changed in "Files changes" here on Github.

Fixing it requires a little bit of git foo: You can revert it by using git checkout master -- pnpm-lock.yaml then git add pnpm-lock.yaml. You could then git commit and push that, but let's squash all your commit together: git reset --soft HEAD~7 && git commit

(The 7 here is the number of commits you've made, so if you add additional commits in between you need to update that number.)

Then finally git push --force-with-lease to replace the commits here with the single squashed commit.

done sir

[faytey]

Hello sir @norswap

[norswap]

Thanks! Did some extra cleanup and merged here: #137