Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library update #105

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Library update #105

merged 1 commit into from
Mar 21, 2023

Conversation

darylldoyle
Copy link
Collaborator

Description of the Change

Updates the svg-sanitiser library to 0.16.0

Changelog Entry

  • Security - Updates the underlying sanitisation library to pull in a security fix.

Credits

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@darylldoyle darylldoyle requested a review from a team as a code owner March 20, 2023 11:38
@darylldoyle darylldoyle self-assigned this Mar 20, 2023
@darylldoyle darylldoyle requested review from faisal-alvi and removed request for a team March 20, 2023 11:38
@jeffpaul jeffpaul added this to the 2.1.0 milestone Mar 20, 2023
@jeffpaul jeffpaul mentioned this pull request Mar 20, 2023
Closed
faisal-alvi
faisal-alvi approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@faisal-alvi faisal-alvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested cases:

  • ✅ SVG uploaded from the Media > Library section.
  • ✅ SVG uploaded from the Media > Add New > (browser uploader; input field)
  • ✅ SVG uploaded from the Media > Add New > (multi-file uploader; drag and drop)
  • ✅ SVG with the core image block.
  • ✅ SVG with the core gallery block.
  • ✅ SVG with the Safe SVG block.
  • ✅ No console errors.
  • ✅ Build command (npm run build) works without any errors.

@jeffpaul jeffpaul merged commit df75aa6 into develop Mar 21, 2023
@jeffpaul jeffpaul deleted the update/sanitiser-lib-0.16.0 branch March 21, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faisal-alvi faisal-alvi faisal-alvi approved these changes

Assignees

@darylldoyle darylldoyle

Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@darylldoyle @faisal-alvi @jeffpaul