Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for missing custom classname on the frontend #130

Merged
merged 4 commits into from
Jul 3, 2023
Merged

Fix for missing custom classname on the frontend #130

merged 4 commits into from
Jul 3, 2023

Conversation

bmarshall511
Copy link
Contributor

Description of the Change

Fixes the missing custom classname on the frontend. It was being applied in the editor, but not when rendering on the front.

Closes #126

How to test the Change

  1. Insert Safe SVG Icon block
  2. Apply a custom class to block
  3. Save page / post
  4. View source in the frontend to verify the class has been applied

Changelog Entry

Fixed - Fix for missing custom classname on the frontend

Credits

Props @bmarshall511

Checklist:

@bmarshall511 bmarshall511 requested a review from a team as a code owner June 21, 2023 13:09
@bmarshall511 bmarshall511 self-assigned this Jun 21, 2023
@bmarshall511 bmarshall511 requested review from faisal-alvi and removed request for a team June 21, 2023 13:09
@jeffpaul jeffpaul added this to the 2.2.0 milestone Jun 28, 2023
@jeffpaul jeffpaul requested review from a team and Sidsector9 and removed request for faisal-alvi and a team June 28, 2023 15:58
Sidsector9
Sidsector9 requested changes Jun 29, 2023
View reviewed changes
includes/blocks/safe-svg/register.php Outdated Show resolved Hide resolved
@jeffpaul jeffpaul requested a review from Sidsector9 June 29, 2023 15:47
@dkotter dkotter mentioned this pull request Jul 3, 2023
Closed
19 tasks
@dkotter dkotter merged commit b530e2e into develop Jul 3, 2023
11 checks passed
@dkotter dkotter deleted the fix/missing-svg-custom-classname-ben branch July 3, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkotter dkotter dkotter approved these changes

@Sidsector9 Sidsector9 Awaiting requested review from Sidsector9

Assignees

@bmarshall511 bmarshall511

Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

Class not applied to Safe SVG Icon block in front end
4 participants
@bmarshall511 @dkotter @Sidsector9 @jeffpaul