update safe-svg block apiVersion to version 3
#133
Conversation
WordPress 6.3 adds a new `apiVersion` which indicates that a block supports being rendered inside an iframed editor.
jeffpaul
requested review from
a team and
ravinderk
and removed request for
a team
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "$schema": "https://schemas.wp.org/trunk/block.json", | |||
| "apiVersion": 2, | |||
| "apiVersion": 3, | |||
There was a problem hiding this comment.
@fabiankaegy I approved this pull request, but I want to confirm whether it will work fine with WordPress 5.7 (plugin minimum dependency).
There was a problem hiding this comment.
@fabiankaegy bumping this back up for your input
There was a problem hiding this comment.
So based on the documentation, v3 of the API is WP 6.3+, whereas v2 is 5.6+. That said, not clear from that if things won't work at all or if it gracefully falls back to an older API version.
Just tested in a WP 5.7 environment and the SVG block doesn't work, whether using v1, v2 or v3 of the Block API. Existing blocks still render but adding a new SVG block throws an error.
Updated to 5.8 and things worked, both on v2 and seemingly on v3 as well. Not a super thorough test but I think we should look to bump our minimum WordPress version to at least 5.8 since it doesn't seem the block works on 5.7 anyway.
Still defer to @fabiankaegy's opinion on if there's any concern with using API v3 on an environment running a WP version less than 6.3. If no concern, I'd suggest we bump the WP version in this PR. Otherwise that can be done in a separate PR and maybe we close this out until 6.3 is our minimum
There was a problem hiding this comment.
I'm fine bumping the WP minimum to 6.1 for that matter, been considering a L-2 support policy for WP so if we bump "tested up to" 6.3 then that would be ok by me.
|
@fabiankaegy is there a reason to keep this in draft or can it move out for review? |
|
@jeffpaul Sorry for the delay here. No concerns from my end. This is fully backward compatible and we can merge it as is I think :) |
Description of the Change
WordPress 6.3 adds a new
apiVersionwhich indicates that a block supports being rendered inside an iframed editor.Closes #
How to test the Change
Changelog Entry
Credits
Props @username, @username2, ...
Checklist: