Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash if SimpleXML is missing #140

Merged
merged 3 commits into from
Aug 7, 2023
Merged

Conversation

sdmtt
Copy link
Contributor

@sdmtt sdmtt commented Aug 1, 2023

Fixes #139

@sdmtt sdmtt marked this pull request as ready for review August 1, 2023 19:00
@sdmtt sdmtt requested a review from a team as a code owner August 1, 2023 19:00
@sdmtt sdmtt requested review from faisal-alvi and removed request for a team August 1, 2023 19:00
@jeffpaul jeffpaul added this to the 2.2.0 milestone Aug 1, 2023
Copy link
Member

@faisal-alvi faisal-alvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, and works as expected! Thank you @sdmtt

Copy link
Member

@faisal-alvi faisal-alvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a minor spacing issue

safe-svg.php Outdated Show resolved Hide resolved
@faisal-alvi faisal-alvi merged commit 175cc44 into 10up:develop Aug 7, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken media management if simplexml is missing
3 participants