Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed fill-rule browser error #152

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Fixed fill-rule browser error #152

merged 1 commit into from
Sep 15, 2023

Conversation

zamanq
Copy link
Contributor

@zamanq zamanq commented Sep 15, 2023

Description of the Change

Fixed the browser error for svg icon that was caused by the fill-rule attribute.
Closes #149

How to test the Change

=> In wp-config.php file, enable script debug: define( 'SCRIPT_DEBUG', true );
=> Create a new page and add the Inline SVG block from block inserter
=> Add any svg image and the browser warning should go away.

Changelog Entry

Fixed - SVG Icon Browser Warning

Credits

Props @zamanq @jeffpaul

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@zamanq zamanq requested a review from a team as a code owner September 15, 2023 07:54
@zamanq zamanq requested review from iamdharmesh and jeffpaul and removed request for a team September 15, 2023 07:54
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @zamanq. Code LGTM and it tests well.

@jeffpaul jeffpaul added this to the 2.2.1 milestone Sep 15, 2023
@jeffpaul jeffpaul merged commit 62c2be8 into develop Sep 15, 2023
11 checks passed
@jeffpaul jeffpaul deleted the fix/149 branch September 15, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser Warning Error for svg icon
3 participants