Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix width and height metadata condition on svg_dimensions function #174

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

sksaju
Copy link
Member

@sksaju sksaju commented Feb 12, 2024

Description of the Change

Remediation work on the PR #154

Closes #

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jeffpaul jeffpaul added this to the 2.3.0 milestone Feb 12, 2024
@sksaju sksaju changed the title fix width and height metadata condtion on svg_dimensions function fix width and height metadata condition on svg_dimensions function Feb 12, 2024
@jeffpaul jeffpaul requested review from peterwilsoncc and removed request for jeffpaul February 12, 2024 21:49
Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good but I left a question inline about the tests and differences I am seeing locally.

@@ -262,6 +262,53 @@ public function test_one_pixel_fix() {
),
),
),
array(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this what wp_get_attachment_metadata() is expected to return following your changes in this and the other PR?

Using svgNoDimensions.svg I don't get a sizes array stored.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterwilsoncc I have updated this as per the actual response from the WP for the svgNoDimensions.svg file.

Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jeffpaul jeffpaul merged commit d4f9dcc into develop Mar 19, 2024
12 of 13 checks passed
@jeffpaul jeffpaul deleted the fix/75-slow-load-times-due-to-svgdimensions-v2 branch March 19, 2024 13:21
@dkotter dkotter modified the milestones: 2.3.0, 2.2.3 Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants