Fix fatal error when "admin_post_thumbnail_html" filter is applied with null "$thumbnail_id" param #196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
The
admin_post_thumbnail_html
filter is allowing the$thumbnail_id
parameter to be null or undefined but the when a callback for that hook is registered in the plugin, the$thumbnail_id
parameter is set to always be defined, thus filter application with just two arguments are throwing fatal errors when the plugin is activated.Closes #195
How to test the Change
functions.php
file add the following commandChangelog Entry
Credits
Props @kmgalanakis
Checklist: