Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minimum supported WordPress version 4.7 #32

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Bump minimum supported WordPress version 4.7 #32

merged 1 commit into from
Feb 16, 2022

Conversation

cadic
Copy link
Contributor

@cadic cadic commented Feb 15, 2022

Description of the Change

Bump minimum supported WordPress version 4.7

Closes #31

Alternate Designs

It's possible to perform alternative workflow around safe-svg:331 to make the call of wp_get_additional_image_sizes optional.

Possible Drawbacks

Loosing support of WordPress prior to 4.7

Verification Process

  1. Install WordPress 4.7
  2. Activate Safe SVG
  3. Upload SVG image
  4. Expected successful upload

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Update - Bump minimum supported WordPress version 4.7

Credits

Props @cadic

@cadic cadic requested a review from a team February 15, 2022 08:09
@cadic cadic self-assigned this Feb 15, 2022
@cadic cadic requested review from iamdharmesh and removed request for a team February 15, 2022 08:09
@cadic cadic added this to the 1.10.0 milestone Feb 15, 2022
@jeffpaul jeffpaul merged commit e1e93f4 into develop Feb 16, 2022
@jeffpaul jeffpaul deleted the bump/issue-31 branch February 16, 2022 19:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamdharmesh iamdharmesh iamdharmesh approved these changes

@darylldoyle darylldoyle Awaiting requested review from darylldoyle

Assignees

@cadic cadic

Labels
None yet
Projects
None yet
Milestone
1.9.10
Development

Successfully merging this pull request may close these issues.

Fatal error with minimum supported WordPress version
3 participants
@cadic @iamdharmesh @jeffpaul