Update/composer install lib

[darylldoyle]

Description of the Change

• This moves the composer installed library to the root and makes sure that we're not including the entire library within the repo.
• It also updates the build steps to run composer install rather than npm run build.

Checklist:

• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my change.
• All new and existing tests passed.

Changelog Entry

• Added - New build step
• Changed - Library location

[jeffpaul]

@dkotter this is probably worth a review to get into the 1.9.10 release to ensure things work smoothly as our first release under 10up / using our GitHub Actions.

[dkotter]

It looks like we have a similar build command in the wordpress-plugin-asset-update.yml file. Should that be updated as well?

[darylldoyle]

Thanks! I missed that other build command. That's been updated now!

[dkotter]

Since we aren't committing this file to the repo anymore, I think we need to add a conditional around this so those that are directly checking this repo out don't end up with a fatal error if they haven't run composer install.

Something like:

Suggested change

	require 'vendor/autoload.php';
	// Try and include our autoloader.
	if ( is_readable( __DIR__ . '/vendor/autoload.php' ) ) {
	require __DIR__ . '/vendor/autoload.php';
	} else {
	add_action( 'admin_notices', function() { ?>
	<div class="notice notice-error">
	<?php /* translators: %1$s: composer command */ ?>
	<p><?php echo wp_kses_post( sprintf( __( 'You appear to be running a development version of Safe SVG. Please run %1$s in order for things to work properly.', 'safe-svg' ), '<code>composer install</code>' ) ); ?></p>
	</div>
	<?php
	} );
	return;
	}

[darylldoyle]

Good call, I've added this in 🙂

[dkotter]

Should probably also add vendor/* into our .gitignore file

[darylldoyle]

@dkotter, thanks for taking a look. I've made those updates to the PR!