Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPUnit tests #71

Merged
merged 11 commits into from
Jul 7, 2022
Merged

PHPUnit tests #71

merged 11 commits into from
Jul 7, 2022

Conversation

iamdharmesh
Copy link
Member

Description of the Change

This PR adds PHPUnit tests and GH action to run tests on PR and push to develop

Closes #70

Alternate Designs

Possible Drawbacks

Verification Process

Try running the tests locally with the this command composer install && composer run test:unit OR Check GH action it should be PASS.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Added - PHPUnit tests.

Credits

Props @iamdharmesh

@iamdharmesh iamdharmesh self-assigned this Jul 4, 2022
@iamdharmesh iamdharmesh modified the milestone: 2.1.0 Jul 4, 2022
@iamdharmesh iamdharmesh requested review from a team and jayedul and removed request for a team July 4, 2022 16:04
@iamdharmesh iamdharmesh marked this pull request as ready for review July 4, 2022 16:05
@jeffpaul jeffpaul requested review from a team and Sidsector9 and removed request for jayedul and a team July 5, 2022 17:42
@jeffpaul jeffpaul modified the milestones: 2.0.3, 2.1.0 Jul 5, 2022
Sidsector9
Sidsector9 approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@Sidsector9 Sidsector9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @iamdharmesh! 🎉

@jeffpaul jeffpaul merged commit 0dc3fca into develop Jul 7, 2022
@jeffpaul jeffpaul deleted the unit-tests branch July 7, 2022 17:50
@jeffpaul jeffpaul modified the milestones: 2.1.0, 2.0.3 Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sidsector9 Sidsector9 Sidsector9 approved these changes

Assignees

@iamdharmesh iamdharmesh

Labels
None yet
Projects
None yet
Milestone
2.0.3
Development

Successfully merging this pull request may close these issues.

Add Unit tests
3 participants
@iamdharmesh @Sidsector9 @jeffpaul