Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Build release zip" GitHub Action. #87

Merged
merged 3 commits into from
Dec 9, 2022
Merged

Conversation

iamdharmesh
Copy link
Member

@iamdharmesh iamdharmesh commented Dec 2, 2022

Description of the Change

PR Adds "Build release zip" GitHub Action to generate the release zip before the actual release and Release Instructions are updated to test generated zip before ship release.

Closes #86

How to test the Change

I forked the repo, merged PR, and tried to generate a release zip by manually running the action.

Changelog Entry

Added - "Build release zip" GitHub Action.

Credits

Props @iamdharmesh @faisal-alvi

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@iamdharmesh iamdharmesh marked this pull request as ready for review December 2, 2022 11:19
@iamdharmesh iamdharmesh requested review from a team and cadic and removed request for a team December 2, 2022 11:19
@iamdharmesh iamdharmesh added this to the 2.1.0 milestone Dec 2, 2022
@iamdharmesh iamdharmesh self-assigned this Dec 2, 2022
cadic
cadic previously approved these changes Dec 5, 2022
CONTRIBUTING.md Outdated Show resolved Hide resolved
@jeffpaul jeffpaul merged commit 895b115 into develop Dec 9, 2022
@jeffpaul jeffpaul deleted the enhancement/86 branch December 9, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a "Build release zip" GitHub Action
4 participants