This repository has been archived by the owner on Mar 7, 2021. It is now read-only.
Segmented Control / Switch Field #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also sets the accessibility value for date, time, and select fields to the selected value. Text fields automatically behave this way.
jeffleeismyhero
changed the title
|
Below is a screenshot of the
This is the field with modified font styling:
|
|
Looking good, @jeffleeismyhero :) |
3lvis
reviewed
Oct 18, 2016
| "id": "segment", | ||
| "title": "My Segment", | ||
| "type": "segment", | ||
| "value": "part_1", |
There was a problem hiding this comment.
Is this needed? I was hoping that maybe we could only get the value from the default values field, otherwise we'll keep it as nil.
There was a problem hiding this comment.
This wasn't needed. :)
|
Merging to |
3lvis
added a commit
that referenced
this pull request
Oct 18, 2016
* Segmented Control / Switch Field (#544) * Add support for Accessibility Labels on text field * Add accessibility label support to other fields This also sets the accessibility value for date, time, and select fields to the selected value. Text fields automatically behave this way. * Add documentation for Accessibility Labels * Correct Markdown syntax for links * Add UISegmentedControl support * Add tests for Segment Control * Update README and STYLING documents for Segments * Update project * Remove the need for setting the value on the segmented field
3lvis
added a commit
that referenced
this pull request
Oct 18, 2016
* Segmented Control / Switch Field (#544) * Add support for Accessibility Labels on text field * Add accessibility label support to other fields This also sets the accessibility value for date, time, and select fields to the selected value. Text fields automatically behave this way. * Add documentation for Accessibility Labels * Correct Markdown syntax for links * Add UISegmentedControl support * Add tests for Segment Control * Update README and STYLING documents for Segments * Update project * Remove the need for setting the value on the segmented field * Update Basic-Swift project to Swift 3
|
👏 Fantastic job, @jeffleeismyhero 👏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the functionality requested in the Feature Request Issue #536. It might also work for the functionality requested in issues #474 and #476.
Field type:
segmentValues: This field takes values in the same format as select fields.
Example JSON
[ { "id": "group", "title": "Group", "sections": [ { "id": "section", "fields": [ { "id": "segment", "title": "Location", "type": "segment", "values":[ { "id":"in_house", "title":"In-house", "default":true }, { "id":"remote", "title":"Remote" } ], "size": { "width": 40, "height": 1 } } ] } ] } ]