Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

The new created safe is not loaded if the "main" owner was changed on the second step of safe creation #2515

Closed
liliya-soroka opened this issue Jul 6, 2021 · 2 comments · Fixed by #2552
Assignees
Labels
Bug 🐛 Something isn't working Major Needs to be fixed for immediate next public release.
Milestone

Comments

@liliya-soroka
Copy link
Member

Description

The new created safe is not loaded if the "main" owner was changed on the second step of safe creation

Environment

  • Browser: Chrome
  • Wallet: MetaMask
  • Safe: any new safe
  • Environment:
    • production (rinkeby, polygon)

Steps to reproduce

  1. Go to create a new safe flow

  2. connect MM account

  3. Go to the second step to define owners
    Current result: the owner is taken from the connected MM

  4. Change owner in the MM and wait till the first owner is updated on the second step

  5. Go to the end of the safe creation

  6. Click Load safe
    Current result: The user is stuck on the loading safe step and the error appears in the console
    image

Expected result : It should be possible to change "main" owner address on the second step of the safe creation

@liliya-soroka liliya-soroka added the Bug 🐛 Something isn't working label Jul 6, 2021
@tschubotz
Copy link
Member

I could reproduce this one. I think in 99% of the cases, people won't change that connected wallet owner. However I would still mark it as major because we had so much trouble with Safes not loading and trouble with reproduction of the bugs, so I think we should fix all reproducible ones.

@tschubotz tschubotz added the Major Needs to be fixed for immediate next public release. label Jul 7, 2021
@katspaugh
Copy link
Member

Possibly a duplicate of #1453.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug 🐛 Something isn't working Major Needs to be fixed for immediate next public release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants