Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Dont reset variables that dont need update #2552

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

juampibermani
Copy link
Contributor

What it solves

Resolves #2515

How this PR fixes it

Safe name doesn't get reset if mm account is changed

How to test it

  • Select to create new safe
  • Set a name and next step
  • Change mm account
  • Complete safe creation

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@juampibermani juampibermani self-assigned this Jul 16, 2021
@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@mmv08
Copy link
Member

mmv08 commented Jul 20, 2021

Just one nitpick: the description doesn't describe what was the reason for the problem at all.

It doesn't answer the question How this PR fixes it but rather What's the behavior like after a fix? Maybe I'm wrong, but I think this question is actually about technical information about the fix.

In this case, it's particularly important because the fix was applied to the generic Stepper component that is also used in other forms, so possibly it can affect them too.

@francovenica
Copy link
Contributor

Works fine for me. I can switch the owner during the 2nd step and the safe loads properly after being created.
I don't see errors in the console related to this issue anymore (I made the comparison between prod now and this PR)

Looks good to me

@mmv08 mmv08 merged commit 9939cf6 into dev Jul 21, 2021
@mmv08 mmv08 deleted the fix/2515-dont-reset-safe-name-on-account-swap branch July 21, 2021 12:57
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The new created safe is not loaded if the "main" owner was changed on the second step of safe creation
4 participants