This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
Bugfix - Owners table sorting is not working correctly #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
matextrem
force-pushed
the
bugfix/owner-table-sort
branch
from
bfc7110
to
783fd1f
Compare
ESLint Summary View Full Report
Report generated by eslint-plus-action |
katspaugh
suggested changes
Jun 1, 2021
|
When you go to the Address Book, the app crashes with this error: |
|
@katspaugh it should be working now 👍 |
|
Looks good to me too |
francovenica
approved these changes
Jun 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
This PR fixes #459
How this PR fixes it
We extended the sorting functionality in order to allow custom sorting methods for each column of the table.
How to test it