-
Notifications
You must be signed in to change notification settings - Fork 363
Use staging and dev links in the network menu #2508
Conversation
@@ -22,9 +22,11 @@ const rinkeby: NetworkConfig = { | |||
environment: { | |||
dev: { | |||
...baseConfig, | |||
safeUrl: 'https://safe-team.dev.gnosisdev.com/app/', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only one that differs from staging.
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
src/config/networks/mainnet.ts
Outdated
@@ -22,9 +22,11 @@ const mainnet: NetworkConfig = { | |||
environment: { | |||
dev: { | |||
...baseConfig, | |||
safeUrl: 'https://safe-team.staging.gnosisdev.com/app/', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This URL is still working (don't know why) but is deprecated. The recommended way is to use the same structure than on the other domains.
https://safe-team-mainnet.staging.gnosisdev.com/app/
Same case below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed! ✅
f4c99b2
to
499e74c
Compare
499e74c
to
2dae37b
Compare
The links are fine in this pr, they all take to https://safe-team-[NETWOKR].staging.gnosisdev.com/app/#/welcome. So it looks good ot me Note: |
What it solves
Resolves #2497.
How this PR fixes it
Adds staging and dev URLs in the network configs.
How to test it
Open the network menu and click on a link, then go back. Repeat for each of the links.