This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
Add breadcrums to app sections #2547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
added 6 commits
July 16, 2021 13:07
juampibermani
approved these changes
Jul 21, 2021
|
The one for the settings is in the middle of the page 😄 |
|
@francovenica good catch. It was an alignment issue when Remove Safe button wasn't show |
|
Looks good now, with and without the "Remove safe" button |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #2540
How this PR fixes it
Uses latest version of
safe-react-componentswhich includes a Breadcrumbs component.Adds this breadcrumb component to all sections of the app
Those which include subsections will show a second level in the breadcrumb with the sub section name.
How to test it
Navigate to each of the different routes and check that Breadcrumbs are shown and behave as expected
Screenshots
Some representative examples:
