-
Notifications
You must be signed in to change notification settings - Fork 363
Conversation
@DiogoSoaress, you can find the selectors here. |
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
Pull Request Test Coverage Report for Build 1384599357
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alles top!
<Paragraph> | ||
{showShortName && <strong>{shortName}:</strong>} | ||
{safeAddress} | ||
</Paragraph> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we update EthHashInfo, we can use it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⛵
The main functionality works fine: Issue: |
Good to hear that all works as expected. I will merge this and have created an issue to fix the bug here. Thanks for testing this so thoroughly 👍 |
What it solves
Resolves #2843
How this PR fixes it
appearance
key to store the new settings.shortName
prefixes.shortName
. It defaults to the value set in settings and does not update the store.Note: the settings do not currently affect any of the UI except the QR modal.
How to test it
Ensure that changes in the 'Appearance' settings save locally.
Open QR modal and check that the value reflects that saved.
Scan the QR code with/without the checkbox checked to see if
shortName
is prepended.Screenshots