Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Enable allowance module for BSC #2952

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Conversation

dasanra
Copy link
Collaborator

@dasanra dasanra commented Nov 3, 2021

What it solves

It partially solves #2571 as we finally deployed allowances smart contracts on BSC

How this PR fixes it

After deploying smart contracts to BSC we can safely enable this feature

How to test it

Just enable a spending limit on BSC and try to use it

@github-actions
Copy link

github-actions bot commented Nov 3, 2021

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Nov 3, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 1 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

github-actions bot commented Nov 3, 2021

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1417812187

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 31.461%

Totals Coverage Status
Change from base Build 1417263810: 0.0%
Covered Lines: 2961
Relevant Lines: 8388

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Nov 3, 2021

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1417846269

Failed tests:

  • ❌ Safe Apps List Safe Apps List

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dasanra dasanra merged commit b0ad56b into dev Nov 19, 2021
@dasanra dasanra deleted the feature/enable-allowance-module-bsc branch November 19, 2021 11:34
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants