Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Fix: don't crash on missing wallet icons #3026

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Fix: don't crash on missing wallet icons #3026

merged 1 commit into from
Nov 19, 2021

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Nov 19, 2021

What it solves

We see people using mystery wallets (the Detected Wallet in onboard?), and having the app crashed on accessing a missing icon.

How this PR fixes it

Don't display any icon if connected to a mystery wallet. Chances are, this wallet might just work.

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1480972643

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.008%) to 31.798%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/AppLayout/Header/components/WalletIcon/index.tsx 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/components/AppLayout/Header/components/WalletIcon/index.tsx 1 0%
Totals Coverage Status
Change from base Build 1480795842: -0.008%
Covered Lines: 2977
Relevant Lines: 8350

💛 - Coveralls

@github-actions
Copy link

Deployment links

🟠 Safe Rinkeby Safe Mainnet 🟣 Safe Polygon 🟡 Safe BSC Safe Arbitrum 🟢 Safe xDai

@github-actions
Copy link

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1481000285

Failed tests:

  • ❌ Safe Balances Safe Balances

@katspaugh katspaugh merged commit 03549c8 into dev Nov 19, 2021
@katspaugh katspaugh deleted the fix-wallet-icon branch November 19, 2021 12:48
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants