Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

When cancelling the apps disclaimer goback instead showing assets #3029

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

yagopv
Copy link
Member

@yagopv yagopv commented Nov 22, 2021

What it solves

Resolves safe-global/safe-react-apps#192

How this PR fixes it

When showing the disclaimer and cancelling then user should be redirected to app list instead showing assets

How to test it

  1. Go to the app list in incognito or with storage initialized
  2. Enter an app
  3. Press Cancelbuttons
  4. Should redirect to the app list instead showing the safe assets

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1489524963

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 31.803%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/safe/components/Apps/index.tsx 0 2 0.0%
Totals Coverage Status
Change from base Build 1481040203: 0.005%
Covered Lines: 2977
Relevant Lines: 8348

💛 - Coveralls

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

Deployment links

🟠 Safe Rinkeby Safe Mainnet 🟣 Safe Polygon 🟡 Safe BSC Safe Arbitrum 🟢 Safe xDai

@github-actions
Copy link

E2E Tests Passed ✅
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1489551636

Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@yagopv yagopv merged commit 8445152 into dev Nov 22, 2021
@yagopv yagopv deleted the feature/redirect-to-app-list-when-cancelling-disclaimer branch November 22, 2021 10:28
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirections on Apps section
3 participants