This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Deployment links
|
Pull Request Test Coverage Report for Build 1545311346
💛 - Coveralls |
E2E Tests Failed Failed tests:
|
mmv08
approved these changes
Dec 6, 2021
katspaugh
approved these changes
Dec 6, 2021
I don't have a way to reproduce a tx like the one in the example. |
Merging as confirmed to work by @mikheevm. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #3115
How this PR fixes it
Nested delegate calls now display that they are a) a delegate call and b) (un-)expected. They also, like #3091, base their legitimacy on whether the address is known or not.
An unexpected, nested delegate call can be found here.
How to test it
The linked example transaction can be used as a PoC for this new warning.
In order to create another, it needs to be done via a script. You would have to use node.js or propose a transaction.
Screenshots
(The following "parent" delegate calls are "unexpected" because our MultiSend contract is not a known address on Rinkeby.)
The known address name was set manually here in order to trigger the warning: