This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
Fix: deep-linked tx – use current timestamp as fallback #3146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
iamacook
commented
Dec 8, 2021
| safeAddress, | ||
| }), | ||
| ) | ||
| history.push(txRoute) |
There was a problem hiding this comment.
Transaction deeplinking must be enabled to test this ticket. Whether we disabled it again after needs to be decided.
katspaugh
reviewed
Dec 8, 2021
| @@ -162,11 +162,13 @@ export const makeTxFromDetails = (txDetails: TransactionDetails): Transaction => | |||
| ? txDetails.detailedExecutionInfo | |||
| : getMultisigExecutionInfo(txDetails) | |||
|
|
|||
| // Will only be used as a fallback whilst waiting on backend tx creation cache | |||
| const now = new Date().getTime() | |||
There was a problem hiding this comment.
JFYI, there's a short version of the same: Date.now() (w/o new).
ESLint Summary View Full Report
Report generated by eslint-plus-action |
katspaugh
changed the title
Deployment links
|
|
E2E Tests Failed Failed tests:
|
Pull Request Test Coverage Report for Build 1555094727
💛 - Coveralls |
|
It looks good to me. The rejected tx in the history shows immediately in the correct date section |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #3069
How this PR fixes it
Navigation to deeplinked transaction after transaction creation was enabled because the error was occurring with this feature. When a deeplinked transaction is opened, and hence loaded from backend via it's
txId, the custom frontend-onlyTransactiontyped object is created.After the immediate creation of a transaction, the fetched transaction may lack a
timestamp. As such, the fallback value was changed from0to the current timestamp because the transaction was effectively created 'now'. Later polls for transactions will overwrite this with the exact timestamp that is eventually fetched.How to test it