Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Add GA appearance/EIP-3770 tracking #3177

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Add GA appearance/EIP-3770 tracking #3177

merged 1 commit into from
Dec 16, 2021

Conversation

iamacook
Copy link
Member

What it solves

Appearance setting tracking.

How this PR fixes it

When a user opens the appearance setting tab a GA tracking event is dispatched. A dynamic (enable/disable) event is dispatched when a user changes their EIP-3770 prefix preferences.

How to test it

  1. Open the appearance settings pane and note the GA event.
  2. Change the prefix preference and note the matching GA event.

@iamacook iamacook self-assigned this Dec 14, 2021
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1578177176

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 32.231%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/safe/components/Settings/Appearance/index.tsx 0 6 0.0%
Totals Coverage Status
Change from base Build 1577488613: -0.02%
Covered Lines: 3088
Relevant Lines: 8506

💛 - Coveralls

@github-actions
Copy link

Deployment links

🟠 Safe Rinkeby Safe Mainnet 🟣 Safe Polygon 🟡 Safe BSC Safe Arbitrum 🟢 Safe xDai

@github-actions
Copy link

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1578233246

Failed tests:

  • ❌ Address book Address book
  • ❌ Safe Apps List Safe Apps List

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@francovenica
Copy link
Contributor

The event is there.
12-15-2021_x(3740)

Note: I can only check in the console since GA is actually not being tracked in PR's. I'll re check in prod

@iamacook iamacook merged commit 8d309ab into dev Dec 16, 2021
@iamacook iamacook deleted the add-appearance-tracking branch December 16, 2021 08:16
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants