-
Notifications
You must be signed in to change notification settings - Fork 363
Conversation
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Deployment links
|
Pull Request Test Coverage Report for Build 1615680193
💛 - Coveralls |
E2E Tests Failed Failed tests:
|
@DiogoSoaress, having this finished is integral to starting #2533. Feel free to take on #2533. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good!
Good job leaving the comments in the txService
leftovers
2 small things that you didn't touch but we could clean up:
-
When changing safe and we enter the reducer
ADD_TOKENS
we are not cleaning tokens that the current safe does not have. I.e, the reducer is keeping leftover tokens -
The method
containsMethodByHash
insrc/logic/tokens/store/actions/fetchTokens.ts
is not being used anywhere and we can delete it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
What it solves
Resolves #3114
How this PR fixes it
All reference to the
/tokens
endpoint has been removed:fetchTokens()
and all related code was deleted as it was seemingly not used at all.getDataDecoderUrl()
/getMasterCopiesUrl()
were modified to rely on the CGW.How to test it
Master copies
Data decoder: create a hex encoded transaction via the Transaction Builder.