This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 363
Migrate Safe Apps endpoint to load directly from CGW #3195
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Assistant Lite All Contributors have signed the CLA. |
iamacook
approved these changes
Dec 20, 2021
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Pull Request Test Coverage Report for Build 1606272316
💛 - Coveralls |
Deployment links
|
E2E Tests Passed ✅ |
katspaugh
reviewed
Dec 20, 2021
@@ -1,6 +1,8 @@ | |||
// import * as gateway from '@gnosis.pm/safe-react-gateway-sdk' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed! 😓 sorry for that!
Looks good to me. Just like the snapshot in the description |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #3129
Now Safe Apps are loaded directly from CGW.
Removed config-service references.
How this PR fixes it
Now Safe Apps are loaded directly from CGW.
How to test it
https://safe-client.staging.gnosisdev.com/v1/chains/{chainId}/safe-apps
Screenshots
Old config-service endpoint
New CGW endpoint