Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Migrate Safe Apps endpoint to load directly from CGW #3195

Merged
merged 5 commits into from
Dec 21, 2021

Conversation

DaniSomoza
Copy link
Contributor

What it solves

Resolves #3129

Now Safe Apps are loaded directly from CGW.

Removed config-service references.

How this PR fixes it

Now Safe Apps are loaded directly from CGW.

How to test it

  1. Go to Safe Apps Section
  2. See the network tab in the dev tools
  3. The new CGW endpoint should be used to fetch Safe Apps List https://safe-client.staging.gnosisdev.com/v1/chains/{chainId}/safe-apps

Screenshots

Old config-service endpoint
Captura de pantalla 2021-12-20 a las 12 10 36

New CGW endpoint
Captura de pantalla 2021-12-20 a las 12 10 43

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Dec 20, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 2 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@coveralls
Copy link

coveralls commented Dec 20, 2021

Pull Request Test Coverage Report for Build 1606272316

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 32.227%

Files with Coverage Reduction New Missed Lines %
src/routes/safe/components/Apps/components/AppCard/index.tsx 1 86.27%
Totals Coverage Status
Change from base Build 1604028580: -0.02%
Covered Lines: 3094
Relevant Lines: 8511

💛 - Coveralls

@github-actions
Copy link

Deployment links

🟠 Safe Rinkeby Safe Mainnet 🟣 Safe Polygon 🟡 Safe BSC Safe Arbitrum 🟢 Safe xDai

@github-actions
Copy link

github-actions bot commented Dec 20, 2021

E2E Tests Passed ✅
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1606297915

@@ -1,6 +1,8 @@
// import * as gateway from '@gnosis.pm/safe-react-gateway-sdk'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed! 😓 sorry for that!

@francovenica
Copy link
Contributor

Looks good to me. Just like the snapshot in the description
Tested it in all networks and it works fine.

@DaniSomoza DaniSomoza merged commit 05131c8 into dev Dec 21, 2021
@DaniSomoza DaniSomoza deleted the migrate-fetch-safe-apps-to-gateway branch December 21, 2021 16:34
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't call config-service directly
5 participants