-
Notifications
You must be signed in to change notification settings - Fork 363
Conversation
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Deployment links
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
E2E Tests Passed ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Question/Issue: Is this pending status being persistent only something for the deep-link view? Is working fine for the deep-link view since refreshing the page keeps showing the pending status, but if you refresh the page while being in queue tab the status goes back to "Needs execution" until you open the tx details Steps: The result is that the pending status is lost until you open the tx details: |
No, it was supposed to be for the queued txns as well. I'll check. |
@francovenica should be good now. ✅ |
One other small bug I noticed though: the sessionStorage (unlike localStorage) somehow isn't shared across tabs in the same browser. Gonna go ahead and merge this for now. |
I think using |
Or we use just localStorage and clear it either on status update or on expiry (I would vote for the latter as it will open up other possibilities). |
Both sound like reasonable approaches. Can you make an issue to address this in the new year? |
Thinking about it further, in our current solution saving the data with an expiration date won't work because we save all the status in one key. It will refresh every time a new tx is made. |
What it solves
Resolves #3194
How this PR fixes it
Local statuses are now persisted in the
sessionStorage
by means of a middleware. The Redux store is initialised by saidsessionStorage
key.How to test it