Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Fix: remove email and update Discord link from error boundary #3233

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Jan 3, 2022

What it solves

Resolves #3220

How this PR fixes it

The <ErrorBoundary> component was updated to remove the email address and update the Discord invitation link.

How to test it

Trigger the app to crash and observe no email link and an updated Discord link.

Screenshots

image

@github-actions
Copy link

github-actions bot commented Jan 3, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@iamacook iamacook changed the title chore: Remove email + update Discord link Remove email and update Discord link from error boundary Jan 3, 2022
@iamacook iamacook assigned iamacook and unassigned iamacook Jan 3, 2022
@github-actions
Copy link

github-actions bot commented Jan 3, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1648843229

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 32.273%

Totals Coverage Status
Change from base Build 1616257116: 0.0%
Covered Lines: 3085
Relevant Lines: 8492

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Jan 3, 2022

Deployment links

🟠 Safe Rinkeby Safe Mainnet 🟣 Safe Polygon 🟡 Safe BSC Safe Arbitrum 🟢 Safe xDai

@github-actions
Copy link

github-actions bot commented Jan 3, 2022

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1648867293

Failed tests:

  • ❌ Safe Apps List Safe Apps List

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@katspaugh katspaugh changed the title Remove email and update Discord link from error boundary Fix: remove email and update Discord link from error boundary Jan 3, 2022
@katspaugh
Copy link
Member

It can't be tested on this branch because we only show the link on prod.
Tested locally. ✅

@katspaugh katspaugh merged commit 256843c into dev Jan 3, 2022
@katspaugh katspaugh deleted the update-discord-link branch January 3, 2022 10:50
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Discord link on the crash screen
3 participants