Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Fix: truncate long token names #3237

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Fix: truncate long token names #3237

merged 1 commit into from
Jan 3, 2022

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Jan 3, 2022

What it solves

Resolves #2251

How this PR fixes it

Long token names are truncated.

How to test it

Screenshots

image

@iamacook iamacook assigned iamacook and unassigned iamacook Jan 3, 2022
@github-actions
Copy link

github-actions bot commented Jan 3, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Jan 3, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1649400297

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 32.273%

Totals Coverage Status
Change from base Build 1648966840: 0.0%
Covered Lines: 3085
Relevant Lines: 8492

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Jan 3, 2022

Deployment links

🟠 Safe Rinkeby Safe Mainnet 🟣 Safe Polygon 🟡 Safe BSC Safe Arbitrum 🟢 Safe xDai

@github-actions
Copy link

github-actions bot commented Jan 3, 2022

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1649434720

Failed tests:

  • ❌ Read-only transaction creation and review Read-only transaction creation and review
  • ❌ Safe Balances Safe Balances

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfetto 🤌

@katspaugh katspaugh changed the title Truncate long token names Fix: truncate long token names Jan 3, 2022
@francovenica
Copy link
Contributor

Looks good to me. Played around with some resolution and it looks fine

image

@iamacook iamacook merged commit 714efe0 into dev Jan 3, 2022
@iamacook iamacook deleted the truncate-token-name branch January 3, 2022 15:37
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long token symbol overlaps other data on the history page (macos 13'')
4 participants