Sdk modules management

[germartinez]

What it solves

Resolves #2797

How this PR fixes it

Uses the safe-core-sdk to call the methods getEnableModuleTx and getDisableModuleTx

How to test it

• Check that the modules list is empty in Settings > Advanced
• Create a new Spending Limit for the first time in Settings > Spending Limit
• Check that a new Safe module was added to the list in Settings > Advanced
• Remove that module using the actions in the right side of the modules table

[github-actions]

CLA Assistant Lite All Contributors have signed the CLA.

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

• Result: ✅ success
• Annotations: 0 total

---

^{Report generated by eslint-plus-action}

[coveralls]

Pull Request Test Coverage Report for Build 1719914404

• 6 of 36 (16.67%) changed or added relevant lines in 5 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.04%) to 31.986%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/logic/safe/utils/spendingLimits.ts	1	2	50.0%
src/routes/safe/components/Settings/Advanced/ModulesTable.tsx	2	4	50.0%
src/logic/safe/utils/modules.ts	2	7	28.57%
src/routes/safe/components/Settings/SpendingLimit/NewLimitModal/Review.tsx	0	10	0.0%
src/routes/safe/components/Settings/Advanced/RemoveModuleModal.tsx	1	13	7.69%

Files with Coverage Reduction	New Missed Lines	%
src/routes/safe/components/Settings/Advanced/ModulesTable.tsx	1	70.97%

Totals
Change from base Build 1718917186:	-0.04%
Covered Lines:	3113
Relevant Lines:	8677

---

💛 - Coveralls

[github-actions]

Deployment links

🟠 Safe Rinkeby	⚪ Safe Mainnet	🟣 Safe Polygon	🟡 Safe BSC	⚫ Safe Arbitrum	🟢 Safe xDai

[github-actions]

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1661170640

Failed tests:

• ❌ Read-only transaction creation and review Read-only transaction creation and review
• ❌ Safe Balances Safe Balances
• ❌ Application Layout Footer exists in the Welcome page and Settings

[katspaugh]

It looks like dev departed from main a bit. You shouldn’t merge main into this branch. Dev is the base.

[katspaugh]

Good catch!

[katspaugh]

Code looks great!
I'm a little worried about the added async-await. Are those calls all try-catch'ed somewhere?
Please test with failing transactions (e.g. super low gas).

[iamacook]

Looking good!

[francovenica]

LGTM

Enabled the module
Added owners to the list
Used that owner to send funds through the module
Disabled the module and re enabled it again with the MC. The owner is still in the list (correct)
Removed all owners from the list
Add an owner once again, re enabling the module once again
Edited the allowance of those owners.
The allowance itself still works fine (the limit on how much can be sent, and actually limiting the owner to do it)

[katspaugh]

@germartinez could you solve the git conflict and merge this? Thanks!

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

• Result: ✅ success
• Annotations: 0 total

---

^{Report generated by eslint-plus-action}

[github-actions]

Deployment links

🟠 Rinkeby	⚪ Mainnet	🟣 Polygon	🟡 BSC	⚫ Arbitrum	🟢 Gnosis Chain