fix: remove redundant PENDING_FAILED status

[iamacook]

What it solves

Resolves #3352

How this PR fixes it

The PENDING_FAILED status was seemingly added as a placeholder and was causing the issue that it was set onError, irregardless of whether the transaction was a signature or execution. It has now been removed and the 'local statuses' converted to a 'pending transactions' array that stores and array of safeTxHashes instead.

The coniditons of performing an off-chain signature now first take into account whether off-chain signing is possible: !isFinalization && canSignOffChain.

The choice to rename isExecution to isFinalization is included here as it is more declarative.

How to test it

The PENDING status should be shown when a signature is requested/the transaction is executed. The button text should also represent whether the transaction needs to be confirmed or executed.

The PENDING statuses should be broadcast across windows/tabs. If you open two tabs/windows of the queue list and execute the transaction in one, it should show the updated status in the other.

This logic affects a lot of cases across all transactions. This has been tested locally across all of the following, but it is best to check them again:

On a 1/? Safe:

• Rejecting the creation of a transaction.
• Creating a transaction and executing it immediately.
• Creating a transaction and executing it, rejecting the request.
• Queueing a transaction and approving it by an owner on a 1/1 Safe.
  • Confirm and execute it by an owner.
  • Confirm and execute it by a third owner.
  • Confirm and execute it by a non-owner.

On a 2/? Safe:

• Create a transaction on a 2/1 Safe.
  • Confirm and execute it by an owner.
  • Confirm and execute it by a third owner.
  • Confirm and execute it by a non-owner.

Creating and executing rejection transactions on the above should also be tested.

[github-actions]

CLA Assistant Lite All Contributors have signed the CLA.

[katspaugh]

✅

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	1	N/A

• Result: ✅ success
• Annotations: 0 total

---

^{Report generated by eslint-plus-action}

[coveralls]

Pull Request Test Coverage Report for Build 1751945508

• 28 of 98 (28.57%) changed or added relevant lines in 17 files are covered.
• 2 unchanged lines in 2 files lost coverage.
• Overall coverage increased (+0.007%) to 33.64%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/logic/safe/store/actions/processTransaction.ts	0	1	0.0%
src/routes/safe/components/Transactions/TxList/TxCollapsed.tsx	0	1	0.0%
src/routes/safe/components/Transactions/TxList/TxCollapsedActions.tsx	0	1	0.0%
src/routes/safe/components/Transactions/TxList/TxDetails.tsx	0	1	0.0%
src/routes/safe/components/Transactions/TxList/TxExpandedActions.tsx	0	1	0.0%
src/routes/safe/components/Transactions/TxList/TxQueueCollapsed.tsx	0	1	0.0%
src/routes/safe/components/Transactions/TxList/hooks/useActionButtonsHandlers.ts	0	1	0.0%
src/routes/safe/components/Transactions/TxList/hooks/useTransactionStatus.ts	0	1	0.0%
src/routes/safe/components/Transactions/TxList/utils.ts	0	1	0.0%
src/logic/safe/store/middleware/notificationsMiddleware.ts	0	3	0.0%

Files with Coverage Reduction	New Missed Lines	%
src/logic/safe/store/actions/createTransaction.ts	1	2.99%
src/routes/safe/components/Transactions/TxList/hooks/useTransactionStatus.ts	1	2.86%

Totals
Change from base Build 1751682935:	0.007%
Covered Lines:	3187
Relevant Lines:	8483

---

💛 - Coveralls

[github-actions]

Deployment links

🟠 Rinkeby	⚪ Mainnet	🟣 Polygon	🟡 BSC	⚫ Arbitrum	🟢 Gnosis Chain

[github-actions]

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1750247557

Failed tests:

• ❌ Address book Address book
• ❌ Safe Apps List Safe Apps List
• ❌ Read-only transaction creation and review Read-only transaction creation and review
• ❌ Safe Balances Safe Balances

[JagoFigueroa]

Hola caballeros! Unfortunately I've been able to reproduce the issue on a safe with 2 owners by doing what Franco shows in the gif:

1. Drain account app, perform a drain of a safe with 2 owners (you can drain them to yourself for testing).
2. Submit and sign tx with the first one.
3. With the second owner, confirm + execute but reject the tx on metamask.
   Tx is shown as:

Edit: Tx is shown as send tx because I only have this asset in the safe :)

Cheers!

[iamacook]

@JagoFigueroa, this issue should now be address. I am putting this into review now but would appreciate your insight on it again once it has passed.

[JagoFigueroa]

Good and bad news.

The tx from the screenshot that I posted above that was prompted to be executed was changed correctly to prompting the user to confirm it instead :)

but repeating the process of rejecting this or any other tx on metmask is making txs get stuck with pending status:

[JagoFigueroa]

Working like a charm now after the fix, thank you @iamacook

I have still a few scenarios left to check tomorrow but it is looking good ;)

[JagoFigueroa]

Buenos días! Testing now on a safe with a 1 / 3 threshold.

1. I create a tx but don't execute it.
2. I go to Queue screen and see that I am prompted to execute the tx (all bueno as it has the required signatures)
   
3. I execute the tx but I reject it on Metamask
4. Transaction changes as if it needs confirmation
   

[katspaugh]

Key comment: use a set or a hash map for pending txns. Easier to lookup and delete items.

[iamacook]

I am aware of the merge conflict. I'll hold off on merging dev here until after review to avoid having lots of file changes polluting the PR.

[katspaugh]

Looketh Goode!

[DiogoSoaress]

✅ well done!

[francovenica]

Jago gave it the thumbs up and I also check it for a bit too check that nothing obvious pops up.

Looks good to me as well.