-
Notifications
You must be signed in to change notification settings - Fork 363
Change Safe App name TextField from readonly to disabled #3366
Conversation
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
E2E Tests Failed Failed tests:
|
Pull Request Test Coverage Report for Build 1744975826
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! 🚀
All bueno. Muchas gracias gentlemen ;) |
&.Mui-disabled { | ||
color: rgba(0, 0, 0, 0.54); | ||
&.Mui-error { | ||
color: ${theme.colors.error}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the theme passed via props like here https://styled-components.com/docs/advanced#theming?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure!! Updated it
What it solves
Resolves safe-global/safe-react-apps#272
How this PR fixes it
By changing the textfield from readOnly to disabled and tweaking some styles
How to test it
Try to add a custom app and click in the safe app name field. Nothing should happen. The label remains in the same place and no animation is performed
Make the app fail for manifest not found. The label should be red and when you click nothing happens