Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Fix: TxBuilder - pass txRecipient #3402

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Fix: TxBuilder - pass txRecipient #3402

merged 1 commit into from
Feb 1, 2022

Conversation

katspaugh
Copy link
Member

What it solves

Resolves #3385

How this PR fixes it

The recipient field wasn't passed to the estimation endpoint in the Safe App Tx Review modal.

How to test it

  • Create a tx with the Tx Builder
  • Estimation should work

Note

A cool trick learned from @DiogoSoaress: you can filter the network request by method like so:

-method:OPTIONS estimations

Minus means exclude.

@github-actions
Copy link

github-actions bot commented Feb 1, 2022

CLA Assistant Lite All Contributors have signed the CLA.

Copy link
Member

@DiogoSoaress DiogoSoaress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

github-actions bot commented Feb 1, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

github-actions bot commented Feb 1, 2022

Deployment links

🟠 Rinkeby Mainnet 🟣 Polygon 🟡 BSC Arbitrum 🟢 Gnosis Chain

@github-actions
Copy link

github-actions bot commented Feb 1, 2022

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1778593577

Failed tests:

  • ❌ Safe Apps List Safe Apps List
  • ❌ Read-only transaction creation and review Read-only transaction creation and review

@francovenica
Copy link
Contributor

It works

The tx builder example that was given where it failed is not failing anymore
Also trying to upgrade the safe is not showing the error message anymore

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1778553612

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 33.65%

Totals Coverage Status
Change from base Build 1777873195: 0.0%
Covered Lines: 3167
Relevant Lines: 8449

💛 - Coveralls

@katspaugh katspaugh merged commit a4b6865 into dev Feb 1, 2022
@katspaugh katspaugh deleted the fix-tx-builder branch February 1, 2022 14:05
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tx builder - Multiple tx causes error in the gas estimation
4 participants