Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Fix: show error msg when tx is not found #3422

Merged
merged 4 commits into from
Feb 7, 2022
Merged

Fix: show error msg when tx is not found #3422

merged 4 commits into from
Feb 7, 2022

Conversation

katspaugh
Copy link
Member

What it solves

Resolves #3414

How this PR fixes it

Displays a loading error when tx isn't found.

How to test it

  • Open an individual tx
  • Change the hash in the URL to some gibberish
  • Error is displayed, click on Go to Queue

Screenshots

Screenshot 2022-02-03 at 14 33 17

@github-actions
Copy link

github-actions bot commented Feb 3, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Feb 3, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor!

@coveralls
Copy link

coveralls commented Feb 3, 2022

@github-actions
Copy link

github-actions bot commented Feb 3, 2022

Deployment links

🟠 Rinkeby Mainnet 🟣 Polygon 🟡 BSC Arbitrum 🟢 Gnosis Chain

@github-actions
Copy link

github-actions bot commented Feb 3, 2022

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1807841816

Failed tests:

  • ❌ Read-only transaction creation and review Read-only transaction creation and review
  • ❌ Safe Balances Safe Balances

Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@francovenica
Copy link
Contributor

francovenica commented Feb 7, 2022

It works fine, but the button "Go to Queue" takes me to /balances.

02-06-2022_x(4150)

Or make it go to the queue (History I think would be better, the queue tab sometimes is just empty)
Or make the button say "Go to Assets"

@katspaugh
Copy link
Member Author

Fixed ✅, thank you!

Screenshot 2022-02-07 at 11 32 43

@francovenica
Copy link
Contributor

francovenica commented Feb 7, 2022

@katspaugh
Copy link
Member Author

Omg, sorry 🤦 Fixed.
Screenshot 2022-02-07 at 18 12 57

@francovenica
Copy link
Contributor

Great. Fixed. Looks good to me

@katspaugh katspaugh merged commit 5a9173e into dev Feb 7, 2022
@katspaugh katspaugh deleted the fix-tx-not-found branch February 7, 2022 18:16
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deep link: infinite loader for not found txns
4 participants