Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

style: remove inconsistent on-chain rejection label #3451

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Feb 7, 2022

What it solves

Resolves #3443

How this PR fixes it

The old on-chain rejection label styling was removed to keep it consistent across tthe app.

How to test it

  1. Create a transaction and corresponding on-chain rejection.
  2. Observe that the on-chain rejection in the group has the usual transaction label style.

Screenshots

image

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

CLA Assistant Lite All Contributors have signed the CLA.

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🙏

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1808211266

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 33.501%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/safe/components/Transactions/TxList/TxCollapsed.tsx 0 1 0.0%
Totals Coverage Status
Change from base Build 1808105153: 0.01%
Covered Lines: 3215
Relevant Lines: 8555

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Deployment links

🟠 Rinkeby Mainnet 🟣 Polygon 🟡 BSC Arbitrum 🟢 Gnosis Chain

@francovenica
Copy link
Contributor

Nice. This was solved faster than I thought. Looks good to me

image

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1808244044

Failed tests:

  • ❌ Read-only transaction creation and review Read-only transaction creation and review
  • ❌ Safe Balances Safe Balances

@iamacook iamacook merged commit d22f2b2 into dev Feb 8, 2022
@iamacook iamacook deleted the on-chain-rejection-label branch February 8, 2022 08:14
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rejection label for tx - Style consistency
4 participants