-
Notifications
You must be signed in to change notification settings - Fork 363
feat: Cookies and privacy policy #3517
feat: Cookies and privacy policy #3517
Conversation
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
E2E Tests Failed Failed tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think Beamer would be counted as analytics. What cookies do they required? The implementation is a bit confusing for me to follow so I'd love to discuss it with you tomorrow. Looking cool though!
Co-authored-by: Aaron Cook <iamacook@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I am still not 100% sure on categorising Beamer as analytical.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice solution with the new cookie category!
What it solves
Resolves #3473
How this PR fixes it
Adds Beamer cookies under the analytics category.
Displays a warning on trying to open the Beamer drawer without the cookies consent.
How to test it
Open the Cookies preferences in the Welcome Page footer and toggle the "Analytics"
Analytics changes
Screenshots