Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

feat: Cookies and privacy policy #3517

Merged
merged 5 commits into from
Feb 17, 2022

Conversation

DiogoSoaress
Copy link
Member

What it solves

Resolves #3473

How this PR fixes it

Adds Beamer cookies under the analytics category.
Displays a warning on trying to open the Beamer drawer without the cookies consent.

How to test it

Open the Cookies preferences in the Welcome Page footer and toggle the "Analytics"

  • If "Analytics" cookies accepted, the sidebar "What's New" button will open the Beamer drawer
  • If "Analytics" cookies is not accepted, the sidebar "What's New" button will prompt the Cookies Banner

Analytics changes

Screenshots

Screen Shot 2022-02-15 at 19 36 35

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Feb 15, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

Deployment links

🟠 Rinkeby Mainnet 🟣 Polygon 🟡 BSC Arbitrum 🟢 Gnosis Chain

@github-actions
Copy link

github-actions bot commented Feb 15, 2022

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1857914817

Failed tests:

  • ❌ Safe Apps List Safe Apps List
  • ❌ Read-only transaction creation and review Read-only transaction creation and review
  • ❌ Safe Balances Safe Balances

Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think Beamer would be counted as analytics. What cookies do they required? The implementation is a bit confusing for me to follow so I'd love to discuss it with you tomorrow. Looking cool though!

src/components/CookiesBanner/index.tsx Outdated Show resolved Hide resolved
src/components/CookiesBanner/index.tsx Outdated Show resolved Hide resolved
src/components/CookiesBanner/index.tsx Outdated Show resolved Hide resolved
src/components/CookiesBanner/index.tsx Outdated Show resolved Hide resolved
src/components/CookiesBanner/index.tsx Outdated Show resolved Hide resolved
@DiogoSoaress DiogoSoaress linked an issue Feb 16, 2022 that may be closed by this pull request
2 tasks
@DiogoSoaress DiogoSoaress changed the title Cookies and privacy policy feat: Cookies and privacy policy Feb 16, 2022
Co-authored-by: Aaron Cook <iamacook@users.noreply.github.com>
@DiogoSoaress DiogoSoaress marked this pull request as ready for review February 16, 2022 12:48
Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I am still not 100% sure on categorising Beamer as analytical.

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution with the new cookie category!

@DiogoSoaress DiogoSoaress merged commit db20b66 into feature-discoverability Feb 17, 2022
@DiogoSoaress DiogoSoaress deleted the cookies-and-privacy-policy branch February 17, 2022 10:14
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend Privacy Policy for new cookies that are used
3 participants