-
Notifications
You must be signed in to change notification settings - Fork 363
Conversation
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
E2E Tests Failed Failed tests:
|
Could you save the custom CSS (is it just plain text?) in a gist and paste the link here? In case we need to migrate it some day. |
Looks like a good start. Has @liliiaorlenko seen this? |
Included the gist in the PR description |
Why so many fonts? Wouldn't Also, since Beamer is in an iframe, you need to import that font in the iframe CSS like so:
Obviously, with a full URL. It might have CORS issues tho. |
Looks great, thanks guys! The only thing left is, if there is a new post would be nice to have a little green circle next to the icons which would show that there is a new not viewed post |
One remark: getting rid of the
@liliiaorlenko ? WDYT @usame-algan ? |
I would only change the background color of feedback section to white color or maybe we can use our new background color #F6F7F8 for the drawer. |
Should be fine with fewer fallbacks, just copy&pasted it from our default config
It seems to work as long as the fonts are included in the destination page. Beamer doesn't provide an option to include/upload custom fonts. Tried using an absolute url and it results in being blocked by CORS policy as you suspected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
What it solves
Resolves #3472
How this PR fixes it
Changes to the Beamer product id that has the custom css styles.
Gist with the custom css: https://gist.github.com/usame-algan/ed48b872686ae2bba12b7ba1848d6868
How to test it
Screenshots