Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

fix: hash approval errors + return txHash #3545

Merged
merged 9 commits into from
Feb 21, 2022
Merged

Conversation

iamacook
Copy link
Member

What it solves

approveHash error notifications, as well as returning txHash.

How this PR fixes it

Relative to the legacy processTransaction error handling, contract errors occuring from approveHash are now displayed in a notification.

A few type changes were made here in order to simplify the error handling as well.

The txHash is also returned here as owner addition/editing checks that the txHash exists in order to update the address book.

@iamacook iamacook self-assigned this Feb 21, 2022
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Feb 21, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 2 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

Deployment links

🟠 Rinkeby Mainnet 🟣 Polygon 🟡 BSC Arbitrum 🟢 Gnosis Chain

@github-actions
Copy link

github-actions bot commented Feb 21, 2022

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1876951635

Failed tests:

  • ❌ Read-only transaction creation and review Read-only transaction creation and review

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Base automatically changed from pending-txs to dev February 21, 2022 12:34
Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@coveralls
Copy link

coveralls commented Feb 21, 2022

Pull Request Test Coverage Report for Build 1876916323

  • 6 of 18 (33.33%) changed or added relevant lines in 4 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 34.54%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/safe/components/Settings/ManageOwners/AddOwnerModal/index.tsx 0 1 0.0%
src/routes/safe/components/Settings/ManageOwners/ReplaceOwnerModal/index.tsx 0 1 0.0%
src/logic/safe/store/actions/createTransaction.ts 5 15 33.33%
Files with Coverage Reduction New Missed Lines %
src/logic/safe/store/actions/createTransaction.ts 6 51.06%
Totals Coverage Status
Change from base Build 1876161152: -0.08%
Covered Lines: 3318
Relevant Lines: 8622

💛 - Coveralls

@iamacook iamacook merged commit 6899e9a into dev Feb 21, 2022
@iamacook iamacook deleted the txhash-error-handling branch February 21, 2022 15:55
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants