Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

fix: use global replace instead of replaceAll #3550

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Conversation

iamacook
Copy link
Member

What it solves

replaceAll errors on Chrome Android.

How this PR fixes it

replaceAll has been exchanged with the legacy global replace.

How to test it

Open an example chainName 'root route' on Chrome Android, e.g. /app/gnosis-chain and observe that the Safe opens correctly.

@iamacook iamacook self-assigned this Feb 22, 2022
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1880530729

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 34.54%

Totals Coverage Status
Change from base Build 1877126792: 0.0%
Covered Lines: 3318
Relevant Lines: 8622

💛 - Coveralls

@github-actions
Copy link

Deployment links

🟠 Rinkeby Mainnet 🟣 Polygon 🟡 BSC Arbitrum 🟢 Gnosis Chain

@github-actions
Copy link

E2E Tests Passed ✅
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1880565396

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that was fast! 😄

@iamacook iamacook merged commit 66710bd into dev Feb 22, 2022
@iamacook iamacook deleted the replace-replaceall branch February 22, 2022 09:12
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants