Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Update safe-core-sdk version #3598

Merged
merged 2 commits into from
Mar 1, 2022
Merged

Update safe-core-sdk version #3598

merged 2 commits into from
Mar 1, 2022

Conversation

germartinez
Copy link
Member

What it solves

Resolves #3476

@github-actions
Copy link

github-actions bot commented Feb 28, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

Copy link
Member

@DiogoSoaress DiogoSoaress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Some tests failed though

@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2022
@germartinez germartinez reopened this Feb 28, 2022
@germartinez
Copy link
Member Author

@iamacook @DiogoSoaress 3 checks are failling with "Unable to create comment because issue is locked."
This happens because the PR was closed and reopened.
Should I create a new PR and close this one or can we bypass those checks? They look good apart from that message.

@iamacook
Copy link
Member

iamacook commented Mar 1, 2022

Should I create a new PR and close this one or can we bypass those checks? They look good apart from that message.

If it will work, sure.

@germartinez
Copy link
Member Author

Mmm, I will create a new PR, I don't have the rights to bypass the checks 🙃

@5afe 5afe unlocked this conversation Mar 1, 2022
@germartinez
Copy link
Member Author

I could unlock the conversation. No new PR needed

@github-actions
Copy link

github-actions bot commented Mar 1, 2022

Deployment links

🟠 Rinkeby Mainnet 🟣 Polygon 🟡 BSC Arbitrum 🟢 Gnosis Chain

@github-actions
Copy link

github-actions bot commented Mar 1, 2022

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1916482401

Failed tests:

  • ❌ Read-only transaction creation and review Read-only transaction creation and review

@germartinez germartinez merged commit 0b3d88a into dev Mar 1, 2022
@germartinez germartinez deleted the update-core-sdk branch March 1, 2022 16:05
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update safe-core-sdk version
3 participants