Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

fix: pass alert key to the openBanner callback #3643

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

DiogoSoaress
Copy link
Member

What it solves

Resolves #3638

How this PR fixes it

The openBanner callback receives a key to set an alert message.

How to test it

Open a Incognito window. The Cookie banner shall display initially without any warning

Screenshots

Screen Shot 2022-03-09 at 14 40 25

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

CLA Assistant Lite All Contributors have signed the CLA.

Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1957567023

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 34.845%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/CookiesBanner/index.tsx 0 3 0.0%
Totals Coverage Status
Change from base Build 1956851480: -0.003%
Covered Lines: 3364
Relevant Lines: 8725

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

Deployment links

🟠 Rinkeby Mainnet 🟣 Polygon 🟡 BSC Arbitrum 🟢 Gnosis Chain

@katspaugh
Copy link
Member

Tested, it's fixed ✅

@katspaugh katspaugh merged commit 4f11272 into dev Mar 9, 2022
@katspaugh katspaugh deleted the fix-banner-warning-incorrect branch March 9, 2022 13:53
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cookie banner warning incorrect
4 participants