-
Notifications
You must be signed in to change notification settings - Fork 363
Conversation
CLA Assistant Lite All Contributors have signed the CLA. |
This isn't based off |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
E2E Tests Failed Failed tests:
|
src/routes/safe/components/Transactions/TxList/hooks/useTransactionType.ts
Outdated
Show resolved
Hide resolved
src/routes/safe/components/Transactions/TxList/TxInfoSettings.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
The CGW does not return this information. |
It looks fine Note: I don't understand why deleting a guard is actually called "Delete guard" but removing other modules like spending limit is "Disable module" and a complete different tx. Although they are both modules are they treated differently? EDIT: I always thought that guards were a special case of a module, but it seems is something completely different, so is natural they are show differently in the tx's. |
Pull Request Test Coverage Report for Build 1963190451
💛 - Coveralls |
What it solves
Resolves #3639
How this PR fixes it
The collapsed label and correct transaction info displays have been added for
set
/deleteGuard
calls. A fallback for any future newSettingsInfo
has been added that will simply show thetype
as well.How to test it
Open
rin:0x6cf158C37354d8da5396fb6d3e965318CCf119c1
on the production CGW and observe the correct labelling of thesetGuard
(in the history) anddeleteGuard
(in the queue). When expanding the transaction, the info should be displayed.Screenshots