Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

chore: use @testing-library/cypress #3746

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Apr 1, 2022

What it solves

Adding @testing-library/cypress

How this PR fixes it

We can now use the well-known findBy* methods in our Cypress tests.

How to test it

The landing.spec.js test should continue to pass.

@iamacook iamacook self-assigned this Apr 1, 2022
@github-actions
Copy link

github-actions bot commented Apr 1, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Apr 1, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 1 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

github-actions bot commented Apr 1, 2022

Deployment links

🟠 Rinkeby Mainnet 🟣 Polygon 🟡 BSC Arbitrum 🟢 Gnosis Chain

Copy link
Member

@DiogoSoaress DiogoSoaress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it

@DiogoSoaress DiogoSoaress merged commit 4672365 into cypress-poc Apr 1, 2022
@DiogoSoaress DiogoSoaress deleted the cypress-testing-library branch April 1, 2022 09:04
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants