Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Add GTM safe apps event tracking #3748

Merged
merged 15 commits into from
Apr 8, 2022
Merged

Add GTM safe apps event tracking #3748

merged 15 commits into from
Apr 8, 2022

Conversation

yagopv
Copy link
Member

@yagopv yagopv commented Apr 1, 2022

What it solves

Resolves safe-global/safe-apps-sdk#309

How this PR fixes it

We are adding to the current GTM container:

  • 4 new variables

image

  • 1 trigger

image

  • 1 Safe App Tag bounded to a GA4 event

image

  • 1 Safe App tag specifying the Measurement ID for the Safe App property

image

How to test it

Analytics changes

Screenshots

@github-actions
Copy link

github-actions bot commented Apr 1, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Apr 1, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

github-actions bot commented Apr 1, 2022

Deployment links

🟠 Rinkeby Mainnet 🟣 Polygon 🟡 BSC Arbitrum 🟢 Gnosis Chain

@coveralls
Copy link

coveralls commented Apr 1, 2022

src/utils/googleTagManager.ts Outdated Show resolved Hide resolved
@yagopv yagopv marked this pull request as ready for review April 6, 2022 09:29
src/routes/safe/components/Apps/components/AppFrame.tsx Outdated Show resolved Hide resolved
src/utils/googleTagManager.ts Outdated Show resolved Hide resolved
src/utils/googleTagManager.ts Outdated Show resolved Hide resolved
src/utils/googleTagManager.ts Outdated Show resolved Hide resolved
src/utils/googleTagManager.ts Outdated Show resolved Hide resolved
src/utils/googleTagManager.ts Outdated Show resolved Hide resolved
src/utils/googleTagManager.ts Outdated Show resolved Hide resolved
@yagopv yagopv requested a review from iamacook April 8, 2022 09:21
@yagopv
Copy link
Member Author

yagopv commented Apr 8, 2022

Made some changes here after an internal discussion in the safe-apps team.

  1. Using new variables for tracking only messages (big amount of events)
  2. Using regular trackEvent for actions as transaction confirmed / rejected or legacy usage of apis
  3. Removed deprecated and params variable as are not really useful (params => sentry same functionality)

Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shaping up nicely dude! I just have a few suggestions.

src/utils/events/safeApps.ts Outdated Show resolved Hide resolved
src/utils/googleTagManager.ts Outdated Show resolved Hide resolved
src/utils/googleTagManager.ts Show resolved Hide resolved
src/utils/googleTagManager.ts Outdated Show resolved Hide resolved
src/utils/googleTagManager.ts Outdated Show resolved Hide resolved
src/utils/googleTagManager.ts Outdated Show resolved Hide resolved
@yagopv yagopv requested a review from iamacook April 8, 2022 10:45
src/utils/googleTagManager.ts Outdated Show resolved Hide resolved
src/utils/googleTagManager.ts Outdated Show resolved Hide resolved
src/utils/googleTagManager.ts Show resolved Hide resolved
@yagopv yagopv requested a review from iamacook April 8, 2022 14:28
Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@yagopv yagopv merged commit 260d61f into dev Apr 8, 2022
@yagopv yagopv deleted the feature/safe-apps-analytics branch April 8, 2022 15:44
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SDK analytics
6 participants