This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 363
fix: set empty names as shortened address #3794
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Assistant Lite All Contributors have signed the CLA. |
iamacook
commented
Apr 19, 2022
Comment on lines
+32
to
+34
useEffect(() => { | ||
dispatch(addressBookFixEmptyNames()) | ||
}, [dispatch]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is temporary and should be removed at some point.
ESLint Summary View Full Report
Report generated by eslint-plus-action |
katspaugh
reviewed
Apr 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea using short addresses! I would go for 4 symbols, not 8, though.
katspaugh
reviewed
Apr 19, 2022
Pull Request Test Coverage Report for Build 2194408563
💛 - Coveralls |
katspaugh
approved these changes
Apr 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #3526
How this PR fixes it
If an empty name makes it's way to the address book reducer (be it by adding or importing), it is set to a shortened version of the given address.
A temporary dispatch sets any existing empty-named address book entries to be the same as the above.
How to test it
Remove the name name of a contact in the locally stored address book. Refresh/navigate to the address book and observe the shortened address be in place of the name.
Screenshots