test: add address book #3803
test: add address book #3803
Conversation
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Pull Request Test Coverage Report for Build 2197152394
💛 - Coveralls |
| } | ||
|
|
||
| describe('Address_book', () => { | ||
| it('Address book entries add/removal', () => { |
There was a problem hiding this comment.
it('should add and remove Address Book entries'
| address:'0x61a0c717d18232711bC788F19C9Cd56a43cc8872' | ||
| } | ||
|
|
||
| describe('Address_book', () => { |
There was a problem hiding this comment.
describe('Address Book', () => {
|
|
||
| describe('Address_book', () => { | ||
| it('Address book entries add/removal', () => { | ||
| cy.visit(`/${RINKEBY_TEST_SAFE}/address-book`) |
There was a problem hiding this comment.
We need add the PUBLIC_URL here, (/app).
| @@ -0,0 +1,65 @@ | |||
| import 'cypress-file-upload'; | |||
There was a problem hiding this comment.
This package is not added to the package.json
| import 'cypress-file-upload'; | ||
| const path = require("path"); | ||
|
|
||
| const NAME = "Owner1" |
There was a problem hiding this comment.
I say we move these common values to a new constants.ts inside of /cypress/integration/ so they can be potentially shared across tests
There was a problem hiding this comment.
I think we can do this after we have more tests that require file uploading
katspaugh
dismissed
DiogoSoaress’s stale review
Let's improve it in further PRs, it's good enough for now.
ESLint Summary View Full Report
[warning] @typescript-eslint/explicit-module-boundary-types
Report generated by eslint-plus-action |
Pull Request Test Coverage Report for Build 2265375838
💛 - Coveralls |
What it solves
Adds e2e test on cypress for the address book
How to test it
Command yarn cypress:open dev
The cypress UI to select tests opens
Select file "address book"