Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

fix: stricter linting across repo #3808

Merged
merged 1 commit into from
Apr 25, 2022
Merged

fix: stricter linting across repo #3808

merged 1 commit into from
Apr 25, 2022

Conversation

iamacook
Copy link
Member

What it solves

Lax linting/prettier

How this PR fixes it

The whole project is now checked for lint and automatically prettified. The linting rules were made stricter.

We should ideally remove '@typescript-eslint/no-explicit-any' as well as enable the default React linter but this resurrected >100 warnings of non/false-typed code and typing this manually started to get out of hand. I have a local stash of this locally but it became quickly apparent that this would like cause bugs/require a full regression.

For now, the added rules and project-wide scanning should improve our committed code.

How to test it

  • Commit unformatted code and see it get automatically 'prettified'
  • Attempt to commit code that goes against our rules and observe a warning that prevents pushing

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@iamacook iamacook requested a review from katspaugh April 25, 2022 10:32
@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2219557523

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 35.575%

Totals Coverage Status
Change from base Build 2208794601: 0.0%
Covered Lines: 3541
Relevant Lines: 9005

💛 - Coveralls

@github-actions
Copy link

Deployment links

🟠 Rinkeby Mainnet 🟣 Polygon 🟡 BSC Arbitrum 🟢 Gnosis Chain

@katspaugh katspaugh requested a review from dasanra April 25, 2022 10:49
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you Aaron!

@iamacook
Copy link
Member Author

I'm going to directly merge this as it's purely dev relevant.

@iamacook iamacook merged commit c059d9b into dev Apr 25, 2022
@iamacook iamacook deleted the stricter-linter branch April 25, 2022 10:58
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants