This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Lax linting/prettier
How this PR fixes it
The whole project is now checked for lint and automatically prettified. The linting rules were made stricter.
We should ideally remove
'@typescript-eslint/no-explicit-any'
as well as enable the default React linter but this resurrected >100 warnings of non/false-typed code and typing this manually started to get out of hand. I have a local stash of this locally but it became quickly apparent that this would like cause bugs/require a full regression.For now, the added rules and project-wide scanning should improve our committed code.
How to test it