Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix while running check #164

Merged
merged 5 commits into from
Sep 27, 2023
Merged

Fix while running check #164

merged 5 commits into from
Sep 27, 2023

Conversation

tdeignan1
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 23, 2023 •
edited
Loading

Codecov Report

Merging #164 (163aaa1) into main (bac5dfc) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@          Coverage Diff          @@
##            main    #164   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          1       1           
  Lines          1       1           
=====================================
  Misses         1       1

tonygaetani
tonygaetani reviewed Sep 27, 2023
View reviewed changes
Copy link
Member

@tonygaetani tonygaetani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the storage.running check from truthiness to a strict check makes sense to me, as well as overriding Composite's onEvent since Decorator only has one child.

It would be nice if we could add a unit test for the change.

tonygaetani
tonygaetani approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@tonygaetani tonygaetani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tdeignan1 tdeignan1 merged commit 8b32952 into main Sep 27, 2023
6 of 7 checks passed
@tdeignan1 tdeignan1 deleted the fix/while-running-check branch September 27, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonygaetani tonygaetani tonygaetani approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdeignan1 @tonygaetani