Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plant Life Cycle visualization in Statistics Screen #123

Closed
9YbQiuEohUu1 opened this issue Sep 14, 2019 · 4 comments
Closed

Plant Life Cycle visualization in Statistics Screen #123

9YbQiuEohUu1 opened this issue Sep 14, 2019 · 4 comments
Assignees
Labels
Milestone

Comments

@9YbQiuEohUu1
Copy link

I love the fact that the app has all sorts of statistics and graphs. Wouldn't it be cool to have the information on the duration of plant's life cycles visualized in a chart?
000

@7LPdWcaW
Copy link
Owner

yes that's a great idea

@7LPdWcaW 7LPdWcaW self-assigned this Sep 14, 2019
@9YbQiuEohUu1
Copy link
Author

I just checked the graph in the alpha and it looks awesome! Noticed a couple of minor issues though:

  1. To my understanding, the number of days is displayed to the right of its segment, which is confusing.

  2. Looks like the name of the plant on the left just occupies valuable space. Since we're not dealing with side-by-side comparison of several plants, maybe it is not needed there?

  3. Stage names are duplicated above and below the graph.

  4. Stages below the graph are not translated.

All things considered, maybe it would be better to 1) use just one list of stages which would specify both the colors and the number of days and 2) maybe organize the list vertically rather than in two rows for better clarity.
crop

@7LPdWcaW
Copy link
Owner

I agree the graph labels are confusing, not sure how else i will be able to change them in the library being used, but i need to look at the colours anyway.

I'll remove plant name to make the graph wider, and the legend has to stay so you know what the colours match to. I'll add translations for them also.

Not sure I agree about removing the above fields, though, but i can see how its just duplicated data, although one is more visual than the other, having both isnt a bad thing

@9YbQiuEohUu1
Copy link
Author

the legend has to stay so you know what the colours match to. I'll add translations for them also.

Not sure I agree about removing the above fields, though,

How about adding a colored rectangle to the stages in the upper field (or coloring the names themselves)? In any case, you are right- duplicated data isn't that big of a deal.

7LPdWcaW added a commit that referenced this issue Sep 26, 2019
Merge branch 'fix/stage-graph' into develop

* fix/stage-graph:
  Fixes stage chart issues
@7LPdWcaW 7LPdWcaW added this to the v2.6 milestone Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants